Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: raise lower pin of invenio-rdm-records #2853

Merged

Conversation

rekt-hard
Copy link
Contributor

@rekt-hard rekt-hard commented Sep 23, 2024

❤️ Thank you for your contribution!

Description

GuestAccessNotifications are directly imported from invenio-rdm-records which only have been added in v10.7.0.

Encountered this issue when setting up an instance with another package which had very loose dependencies (no upper pin of any package). v10.0.0 of rdm-records was installed, which still satisfied the current restriction but led to an error down the way when importing guest access notifications in setup.cfg, which have been added in v10.7.0.

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

rekt-hard and others added 2 commits September 23, 2024 11:40
* `GuestAccessNotifications` are directly imported from
  invenio-rdm-records which have been added in v10.7.0
* the deposit form logic for handling empty files is included in
  invenio-rdm-records v10.8.3
@max-moser max-moser merged commit 0cd5b26 into inveniosoftware:maint-v12.x Sep 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants